If you're repainting use a tumbler with brass medium. For just a few small peices use Brasso and cotton balls or tissues.
If you're not repainting the trains, don't clean the brass with more than a dry paint brush or damp with water rag. The brass should have a patina.
It's common for new collectors to regret their efforts after cleaning and polishing.